Don't allow checking if None
is within the bounds
#1140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never supported, a
ValueError
would be raised ifNone
was passed to__contains__
. Now we assert to make it clear that it's not allowed.In the future we should probably change
Bounds
to always allowNone
as bounds and make_T
simply bound toComparable
, as supportingNone
depending on the generic type makes it very hard to provide correct type hints.