Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for str formatting of Price and Power types #81

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add tests for str formatting of Price and Power types #81

merged 2 commits into from
Dec 10, 2024

Conversation

shsms
Copy link
Contributor

@shsms shsms commented Dec 10, 2024

No description provided.

@shsms shsms requested a review from a team as a code owner December 10, 2024 12:30
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Dec 10, 2024
@shsms shsms self-assigned this Dec 10, 2024
@shsms shsms enabled auto-merge December 10, 2024 12:31
camille-bouvy-frequenz
camille-bouvy-frequenz approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@camille-bouvy-frequenz camille-bouvy-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shsms shsms added this pull request to the merge queue Dec 10, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit bd9e52d Dec 10, 2024
14 checks passed
@shsms shsms deleted the test-formatting branch December 10, 2024 15:47
nhatcher-frequenz
nhatcher-frequenz approved these changes Dec 10, 2024
View reviewed changes
Copy link

@nhatcher-frequenz nhatcher-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

The tests are actually useful as you can wonder if it should be -103.00 USD or USD -103.00. Although since this is only for pretty printing is irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhatcher-frequenz nhatcher-frequenz nhatcher-frequenz approved these changes

@camille-bouvy-frequenz camille-bouvy-frequenz camille-bouvy-frequenz approved these changes

Assignees

@shsms shsms

Labels
part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shsms @camille-bouvy-frequenz @nhatcher-frequenz