Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input validation checks for the Client Requests #40

Conversation

camille-bouvy-frequenz
Copy link
Collaborator

Add some of the input validation checks described in #86. Note that this checks for only the ones that can be validated in the client (e.g. the Client does not have knowledge of which delivery_area is valid or not, so it can not check for that).

@camille-bouvy-frequenz camille-bouvy-frequenz requested a review from a team as a code owner August 29, 2024 16:48
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:docs Affects the documentation labels Aug 29, 2024
Copy link

@micaebe micaebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camille-bouvy-frequenz camille-bouvy-frequenz added this pull request to the merge queue Sep 11, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 20f9536 Sep 11, 2024
14 checks passed
@camille-bouvy-frequenz camille-bouvy-frequenz deleted the add-validation-rules branch September 11, 2024 14:15
@camille-bouvy-frequenz camille-bouvy-frequenz added this to the v1.0.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants