Add component states and error codes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Removed the initialisation to None for the parameters `page_size` and `page_token` in pagination `Params` as they are no longer optional due to the change in frequenz-floss/frequenz-api-common#232 This PR fixes the CI failures in #44
Signed-off-by: cyiallou - Costas <[email protected]>
Signed-off-by: cyiallou - Costas <[email protected]>
cyiallou
force-pushed
the
add_component_states
branch
from
89e52e5 to
dbc6d51
Compare
|
Rebased to latest main branch. |
llucax
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM.
I have done a more high-level abstraction of all microgrid components in the upgrade of the microgrid client to the microgrid API v0.17 (which also finally switches to the v1 in common), so this will probably change in a near future.
We need to talk to see if this abstraction I wrote makes sense for other services too, but in case you want to give some early feedback, it is part of this PR:
My idea is to basically move everything in src/frequenz/client/microgrid/component and metrics, as well as the top-level modules related to _id.py, _location.py, _microgrid_info.py, _lifetime.py and _delivery_area.py to this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component state codes and error codes similar to #11