Improve docs and fix copy() type
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marenz
previously approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
The `TypeVar`s `_InputT` and `_OutputT` are not really private, as they are used in public classes, so they should be public so they render correctly in the docs. We also add documentation to them. Signed-off-by: Leandro Lucarella <[email protected]>
This is the recommendation in Google-style and is also necessary to enable some of the `pydoclint` checks. Signed-off-by: Leandro Lucarella <[email protected]>
They are used as default for public symbols, so they should be public too, so they render in the documentation. Signed-off-by: Leandro Lucarella <[email protected]>
Otherwise the copied type can't be used as the real type of the subclass. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
generics-docs
branch
from
a68541f to
1111b65
Compare
|
Rebased to solve conflicts and enabled auto-merge, needs another approval. |
Marenz
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeVars publictypingas top-levelSelfinstead ofRetryStrategyincopymethod signature