Bump protobuf and grpcio dependencies
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
andrew-stevenson-frequenz and
daniel-zullo-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
|
This is technically a breaking change, so we might want to wait to merge it if there are any planned fix releases for v0.17.x. |
llucax
added
type:tech-debt
The `protobuf` version 4.25.x will go out of support soon(ish), on 31 Mar 2025. Since we don't need to keep compatibility to any legacy code, we can bump it in advance as a preparation. The `googleapis-common-protos` version was also bumped to 1.65.0, as the previous version was too old to work with the new `protobuf` version. https://protobuf.dev/support/version-support/#python Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
bump-protobuf
branch
from
1c7d103 to
4869626
Compare
daniel-zullo-frequenz
approved these changes
Sep 18, 2024
tiyash-basu-frequenz
approved these changes
Sep 18, 2024
|
@tiyash-basu-frequenz does the approval means it is ok to merge now? |
|
Yep, it's ok to merge it, since it does not touch proto files. |
|
But Python-wise is technically a breaking change, so it shouldn't be released as v0.17.x. This is where having binding and spec files start to get really messy 😬 I guess since we are in pre-1.0 and it is a minor breaking change (you just need to bump deps) it might be OK to make an exception and release in v0.17.x if needed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
protobufversion 4.25.x will go out of support soon(ish), on 31 Mar 2025. Since we don't need to keep compatibility to any legacy code, we can bump it in advance as a preparation.The
googleapis-common-protosversion was also bumped to 1.65.0, as the previous version was too old to work with the newprotobufversion.https://protobuf.dev/support/version-support/#python