Merge v0.17.1 into v0.x.x #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <[email protected]>
This is to make sure we pull a fix for the `protobuf` and `grpcio` versions used to generate the python files. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
We can't use wide dependencies because otherwise when building the wheel, the latest version is used, but the generate code should use the minimum supported version for the generation, not the latest one. See: https://protobuf.dev/support/cross-version-runtime-guarantee/ Signed-off-by: Leandro Lucarella <[email protected]>
This is to avoid an issue with some outdated `griffe` imports. While upgrading the dependency we need to remove the `custom_templates` option that we don't use, as it was previously ignored but now the plugin checks if the directory exists and fails if it doesn't. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
thea-leake and
daniel-zullo-frequenz
and removed request for
a team
* tag 'v0.17.1': Bump mkdocstrings dependencies Pin grpc related dependencies Reformat `pyproject.toml` using taplo Bump frequenz-api-common from 0.6.1 to 0.6.2 Clear release notes Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
merge-0.17.1
branch
from
aa83d4f to
bad43dd
Compare
github-actions
bot
added
part:docs
|
Why was the v0.17.x branch created? It could all have been done on v0.x.x. |
As said on Slack only as an oversight and following the default behavior that |
|
As mentioned on slack, we can take this in, and immediately follw with breaking changes. |
tiyash-basu-frequenz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlusing taplo