Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overview and description of the Frequenz Microgrid API #142

Merged

Conversation

tiyash-basu-frequenz
Copy link
Contributor

No description provided.

@tiyash-basu-frequenz tiyash-basu-frequenz added this to the v0.16.0 milestone Sep 29, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz self-assigned this Sep 29, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz requested a review from a team as a code owner September 29, 2023 14:45
@tiyash-basu-frequenz tiyash-basu-frequenz linked an issue Sep 29, 2023 that may be closed by this pull request
@github-actions github-actions bot added part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files labels Sep 29, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Sep 29, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz linked an issue Sep 29, 2023 that may be closed by this pull request
@tiyash-basu-frequenz tiyash-basu-frequenz removed this from the v0.16.0 milestone Sep 29, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tiyash-basu-frequenz tiyash-basu-frequenz force-pushed the docs branch 2 times, most recently from 1066b56 to 2b65ed7 Compare October 4, 2023 09:16
@tiyash-basu-frequenz
Copy link
Contributor Author

Typo found here:
wil -> will

Fixed

llucax
llucax previously approved these changes Oct 5, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tiyash-basu-frequenz
Copy link
Contributor Author

Rebased on latest upstream head.

README.md Outdated

- **Component Graphs:** The API provides a way to list connections between
components. Connections are represented as pairs of component IDs, describing
an abstract flow of current according to the passive sign convention. The

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this wording a bit confusing. I suggest to mention that this graph is directed. Otherwise the point about the passive sign convention doesn't make sense. Furthermore I'd suggest to write ... "an abstracted flow of current ..." because I understand that there is an "abstract flow". Also we are following the passive the passive sign convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines you are referring to do not talk about graphs at all. How this turns into a graph is explained in the next line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the term directed in the next line where it mentions graphs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore I'd suggest to write ... "an abstracted flow of current ..." because I understand that there is an "abstract flow". Also we are following the passive the passive sign convention.

Difficult to follow you here. I updated the text again. Note that we want to keep it high-level and not add too much tech detail here.

@tiyash-basu-frequenz tiyash-basu-frequenz added this pull request to the merge queue Oct 6, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit 4b2377a Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API documentation Specify that timestamps are in UTC
6 participants