-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic noble migration check script #7334
Draft
legoktm
wants to merge
3
commits into
develop
Choose a base branch
from
stg-upgrade-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still thinking of a few more checks to add, but I think this is ready for review + merge and other checks can be added incrementally. |
legoktm
commented
Nov 12, 2024
securedrop/debian/config/usr/bin/securedrop-noble-migration-check.py
Outdated
Show resolved
Hide resolved
legoktm
force-pushed
the
stg-upgrade-check
branch
from
November 12, 2024 20:09
91a2314
to
d685227
Compare
I plan to port this to Rust based on #7332 (comment). |
legoktm
force-pushed
the
stg-upgrade-check
branch
from
November 14, 2024 21:52
d685227
to
b2408f6
Compare
Now that this is in Rust, need to do a few more cargo vet reviews:
The main new dependency triggering reviews is |
So it can look inside compressed debs.
Establish a folder where we can build Rust binaries that will be shipped in the securedrop-config deb. That package is now architecture-dependent and only built for amd64. We are using Rust because a statically compiled binary is going to be the most robust option during a system upgrade when Python itself is being removed and installed (not to mention all the other Rust benefits).
Perform a number of checks to ensure the system is ready for the noble migration. The results are written to a JSON file in /etc/ that other things like the JI and the upgrade script itself can read from. The script is run hourly on a systemd timer but can also be run interactively for administrators who want slightly more details. Refs #7322.
legoktm
force-pushed
the
stg-upgrade-check
branch
from
November 14, 2024 23:55
ecc833f
to
ffbfd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Perform a number of checks to ensure the system is ready for the noble migration. The results are written to a JSON file in /etc/ that other things like the JI and the upgrade script itself can read from.
The script is run hourly on a systemd timer but can also be run interactively for administrators who want slightly more details.
Refs #7322.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist