Support Debian 11 for dev env #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards https://github.com/freedomofpress/securedrop-docs/issues/255 While testing the dev env on Debian 11 Bullseye, was not able to install the development requirements due to an error on pyenchant. Bumping the req to a recent version resolved for me.
|
@tesitura Please take this for a spin and see if it unblocks you! |
|
Tested on both Debian 10 and a fresh Debian 11 system. Works for me. @conorsch +1 from me :) |
|
Marking ready for review. @kushaldas tried it and liked it, and @tesitura was also able to spin up the VM environments on Bullseye, with this change in the mix. There are still some superficial docs updates required, e.g. mentioning testing Debian 11, but this seems to be all that's necessary diff-wise so far. |
kushaldas
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards freedomofpress/securedrop-dev-docs#9 , adding support for Debian 11
While testing the dev env on Debian 11 Bullseye, was not able to install
the development requirements due to an error on pyenchant. Bumping the
req to a recent version resolved for me.
Marking as a draft because I haven't tested on Buster, and there may be more changes that should be appended here (as well as changes to the docs).
Testing
You must use a Debian 11 machine to test! Following the docs in https://docs.securedrop.org/en/latest/development/setup_development.html#install-python-requirements , make sure you see no errors (or report ones you do encounter!).
Deployment
So far, dev-env only.
Checklist
I haven't performed a diff review, but this is explicitly a dev req.