Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Ports Collection is now git-based #250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

The Ports Collection is now git-based #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FreeBSD does not currently accept pull requests. This is a read-only mirror from SVN.
FreeBSD does accept pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make sure that people know of the still experimental nature of prs.


Please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).
Comment on lines +1 to 3
Copy link
Contributor

@concussious concussious Jun 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FreeBSD does accept pull requests.
Please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).
# FreeBSD Ports Collection Contribution Guidelines
Contributions may be submitted to the FreeBSD Ports Collection via one of three methods:
- Attachments to [Bugzilla tickets](https://bugs.freebsd.org) are preferred, as this notifies existing maintainers.
- Code reviews on [Phabricator](https://reviews.freebsd.org/differential) are accepted by some maintainers.
- GitHub Pull Requests are an experimental feature and should expect additional delay.
To learn more about contributing to the FreeBSD Ports Collection, please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL more about this issue and edited my suggestion above. One thumbs up emoji appeared before today's edit and does not reflect the new suggestion.