Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eject the CLAP features as AUv2 tags #325

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

baconpaul
Copy link
Collaborator

Addresses #324

@defiantnerd
Copy link
Collaborator

Looks fine - just a thought: should we make first character uppercase?

this is all lowercase: https://github.com/free-audio/clap/blob/27f20f81dec40b930d79ef429fd35dcc2d45db5b/include/clap/plugin-features.h#L39

and the Apple examples have first character uppercase.

what do you think?

@baconpaul
Copy link
Collaborator Author

Yeah I thought about that but my instinct was to not mess with them. But i think you are correct.

It's super easy to do an if a < tag[0] < z tag0 = topper tag0 and probably a smart choice.

Let me toss that in.

@baconpaul
Copy link
Collaborator Author

OK pushed.

Shortcircuit now gets

  <key>tags</key>
        <array>
          <string>Instrument</string>
          <string>Sampler</string>
          <string>Synthesizer</string>
          <string>Free and Open Source</string>
        </array>
      </dict>

@defiantnerd defiantnerd merged commit 705df27 into free-audio:main Oct 31, 2024
19 checks passed
baconpaul added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants