fix: permission check for listing wiki in /apps

frappe · Dec 10, 2024 · 4dbbbc1 · 4dbbbc1
1 parent a7f9342
commit 4dbbbc1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/wiki/hooks.py b/wiki/hooks.py
@@ -13,7 +13,7 @@
 		"logo": "/assets/wiki/images/wiki-logo.png",
 		"title": "Wiki",
 		"route": "/app/wiki",
-		# "has_permission": "erpnext.check_app_permission",
+		"has_permission": "wiki.utils.check_app_permission",
 	}
 ]
 

diff --git a/wiki/utils.py b/wiki/utils.py
@@ -0,0 +1,14 @@
+import frappe
+
+
+def check_app_permission():
+	"""Check if user has permission to access the app (for showing the app on app screen)"""
+
+	if frappe.session.user != "Administrator":
+		return True
+
+	roles = frappe.get_roles()
+	if "Wiki Approver" in roles:
+		return True
+
+	return False