chore: Merge develop to main #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This 2 templates will be installed if erpnext is present in the system. depends on #208
This is initially done on the client script as it is implicit. user can always choose different formats. after sometime will make them default on the server side.
- Add new default print format for sales order
added loading default format for sales order
recently, changed logic to only render fields if value is present. however, this caused an issue with page fields, as they are always empty and are updated by wkhtmltopdf.
style & applyStyleToHeader wasn't added to the new columns
this will break styled text, but i think plain text is more used. chrome adds unnecessary tags so only saving text for now
we save font details saved in json object and then we generate url from it using jinja template. there was a edge case where `;` was not being added at the end of normal weight. incorrect https://fonts.googleapis.com/css2?family=JetBrains%20Mono:ital,wght@0,400;0,5001,400 correct https://fonts.googleapis.com/css2?family=JetBrains%20Mono:ital,wght@0,400;0,500;1,400
removed format v1 as it was very similar to v2. updated format for relative column containers.
as generating the image is a slow operation, we should do it at the end
maharshivpatel
changed the title
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.