fix: check for recipients only while sending mail

frappe · Nov 22, 2024 · eaf8946 · eaf8946
1 parent af217d0
commit eaf8946
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/mail_client/mail_client/doctype/outgoing_mail/outgoing_mail.json b/mail_client/mail_client/doctype/outgoing_mail/outgoing_mail.json
@@ -74,7 +74,6 @@
    "fieldtype": "Table",
    "label": "Recipients",
    "options": "Mail Recipient",
-   "reqd": 1,
    "search_index": 1
   },
   {
@@ -473,7 +472,7 @@
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2024-11-20 10:47:08.592108",
+ "modified": "2024-11-22 14:34:10.362892",
  "modified_by": "Administrator",
  "module": "Mail Client",
  "name": "Outgoing Mail",

diff --git a/mail_client/mail_client/doctype/outgoing_mail/outgoing_mail.py b/mail_client/mail_client/doctype/outgoing_mail/outgoing_mail.py
@@ -76,6 +76,11 @@ def validate(self) -> None:
 			self.validate_max_message_size()
 
 	def on_submit(self) -> None:
+		if not self.recipients:
+			frappe.throw(
+				_("Please add at least one recipient before sending the mail."), frappe.MandatoryError
+			)
+
 		self.create_mail_contacts()
 
 		status = "Pending"