Allow to Set Different Certificate Print Format for each LMS Course #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice job rola |
|
@Rola-anvil I don't understand the need for a link field in the LMS Course doctype. When creating a certificate, it considers the default print format set. You can just make your desired format as default. |
|
@pateljannat Thanks for replying. |
pateljannat
requested changes
Oct 25, 2023
| "description": null, | ||
| "docstatus": 0, | ||
| "doctype": "Custom Field", | ||
| "dt": "LMS Course", |
There was a problem hiding this comment.
@Rola-anvil why add a custom field in LMS Course doctype when you can add a standard field.
There was a problem hiding this comment.
Also, you have made the changes in the main branch of your fork. Can you create another branch for this feature instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow the system to create different certificates for each course