fix: course when instructor is not set #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great Job @tahir-zaqout |
niraj2477
reviewed
Aug 10, 2023
lms/lms/utils.py
Outdated
| @@ -156,15 +156,15 @@ def get_tags(course): | |||
| def get_instructors(course): | |||
| instructor_details = [] | |||
| instructors = frappe.get_all( | |||
| "Course Instructor", {"parent": course}, ["instructor"], order_by="idx" | |||
| "Course Instructor", {"parent": course}, ["instructor"], order_by="idx", pluck="instructor" | |||
There was a problem hiding this comment.
No of pluck here. Below change would do
|
This PR will fix : #587 |
pateljannat
requested changes
Aug 25, 2023
pateljannat
changed the title
Passing run #204 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instructors = frappe.get_all(
"Course Instructor", {"parent": course}, ["instructor"], order_by="idx"
)
it return like
[
{"instructor": "user1"},
{"instructor": "user2"}
]
and the
if not instructors:
instructors = frappe.db.get_value("LMS Course", course, "owner").split(" ")
return ["user1", "user2"]
and it make error if get all return []
because instructor.instructor at https://github.com/frappe/lms/blob/main/lms/lms/utils.py#L167