Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding #1085

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat: onboarding #1085

merged 5 commits into from
Oct 31, 2024

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Oct 29, 2024

We improved the onboarding experience for course creators. They now see a clear action when there are no courses in the system.

Screenshot 2024-10-30 at 9 45 25 PM

The card leads them to the course form with better instructions on the form fields.

Screenshot 2024-10-30 at 9 45 41 PM

The same experience is provided for batches.

Screenshot 2024-10-30 at 9 58 12 PM

Empty state for a student

Screenshot 2024-10-31 at 11 13 14 AM

Additional: Fetching course data for the course list was taking time. This has been improved by adding all important statistics such as Lesson count, Enrollment count, and Average Rating to the course doctype itself. A scheduled script runs hourly that keeps updating these numbers.

Copy link

cypress bot commented Oct 29, 2024

lms    Run #762

Run Properties:  status check passed Passed #762  •  git commit e77b641cfe ℹ️: Merge 22b1f22df427b020d71fc3cfa8b5fe4f22334c7c into cf166b3a572cb38a2a6fafae8376...
Project lms
Branch Review new-onboarding
Run status status check passed Passed #762
Run duration 00m 29s
Commit git commit e77b641cfe ℹ️: Merge 22b1f22df427b020d71fc3cfa8b5fe4f22334c7c into cf166b3a572cb38a2a6fafae8376...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat marked this pull request as ready for review October 31, 2024 04:35
@pateljannat pateljannat merged commit 64b54b0 into frappe:develop Oct 31, 2024
5 checks passed
@pateljannat pateljannat deleted the new-onboarding branch October 31, 2024 06:05
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants