chore: fix fetch_if_empty for min_days_bw_disbursement_first_repayment #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify copy poc-staging |
✅ Pull request copies have been created
|
anandbaburajan
added a commit
that referenced
this pull request
Oct 12, 2023
#98) (#99) * chore: fix fetch_if_empty for min_days_bw_disbursement_first_repayment * chore: min_days_bw_disbursement_first_repayment should be int (cherry picked from commit 08becdd) Co-authored-by: Anand Baburajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a framework bug (related to frappe/frappe#22442) where if a int field with
fetch_fromandfetch_if_emptyis intentionally set as 0, it still fetches the value from the parent doc. This affects themin_days_bw_disbursement_first_repaymentfield, so manually handling the fetching part in client and server side.