fix: closed status in loan disbursement #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested changes
Jan 1, 2025
|
|
||
| loan_dis = frappe.db.get_all( | ||
| "Loan Disbursement", | ||
| filters={"status": ["!=", "Closed"]}, |
There was a problem hiding this comment.
We have just introduced the status field, whats the point of checking status here?
| ) | ||
| for ld in loan_dis: | ||
| if ld.docstatus == 0: | ||
| frappe.db.set_value("Loan Disbursement", ld.name, "status", "Draft", update_modified=False) |
There was a problem hiding this comment.
Making one single query for every loan will take lot of time, we have 3 statuses to update. Can you do it just 3 update queries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, add a status field in the loan disbursement. When the loan repayment schedule is closed, the loan disbursement should also be automatically marked as closed.