fix: close employee loan on write off #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
changed the title
|
Please note your two MariaDB commits slipped in. You might want to correct the git history. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* fix: exclude written off amount while calculating loan repayment * ci: use mariadb:10.6 * ci: use mariadb * fix: revert exclude written off amount while calculating loan repayment * fix: close employee loan on write off (cherry picked from commit d32ef21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user did a write off for a loan but when he runs the payroll through Frappe HR, the system still fetches the loan which had been written off. The reason was that the loan wasn't closed after write off. Now, the loan would be closed after a write off if there's no pending principal amount.