fix: Loan Reco updates

lending/loan_management/utils.py

@@ -120,10 +120,11 @@ def get_ld_matching_query(bank_account, exact_match, transaction):
 			(ref_rank + party_rank + 1).as_("rank"),
 			ConstantColumn("Loan Disbursement").as_("doctype"),
 			loan_disbursement.name,
-			loan_disbursement.disbursed_amount,
-			loan_disbursement.reference_number,
+			(loan_disbursement.disbursed_amount).as_("paid_amount"),
+			(loan_disbursement.reference_number).as_("reference_no"),
 			loan_disbursement.reference_date,
-			loan_disbursement.applicant_type,
+			(loan_disbursement.applicant_type).as_("party_type"),
+			(loan_disbursement.applicant).as_("party"),
 			loan_disbursement.disbursement_date,
 		)
 		.where(loan_disbursement.docstatus == 1)
@@ -158,10 +159,11 @@ def get_lr_matching_query(bank_account, exact_match, transaction):
 			(ref_rank + party_rank + 1).as_("rank"),
 			ConstantColumn("Loan Repayment").as_("doctype"),
 			loan_repayment.name,
-			loan_repayment.amount_paid,
-			loan_repayment.reference_number,
+			(loan_repayment.amount_paid).as_("paid_amount"),
+			(loan_repayment.reference_number).as_("reference_no"),
 			loan_repayment.reference_date,
-			loan_repayment.applicant_type,
+			(loan_repayment.applicant_type).as_("party_type"),
+			(loan_repayment.applicant).as_("party"),
 			loan_repayment.posting_date,
 		)
 		.where(loan_repayment.docstatus == 1)

lending/patches/v15_0/generate_loan_repayment_schedule.py

@@ -16,18 +16,18 @@ def execute():
 		return
 
 	for loan in frappe.get_all("Loan", filters={"is_term_loan": 1, "docstatus": ["!=", 2]}):
-		loan = frappe.get_cached_doc("Loan", loan.name)
+		loan_doc = frappe.get_cached_doc("Loan", loan.name)
 		loan_repayment_schedule = frappe.new_doc("Loan Repayment Schedule")
 		loan_repayment_schedule.flags.ignore_validate = True
-		loan_repayment_schedule.loan = loan.name
-		loan_repayment_schedule.loan_product = loan.loan_type
-		loan_repayment_schedule.loan_amount = loan.loan_amount
-		loan_repayment_schedule.monthly_repayment_amount = loan.monthly_repayment_amount
-		loan_repayment_schedule.posting_date = loan.posting_date
-		loan_repayment_schedule.status = get_status(loan.status)
+		loan_repayment_schedule.loan = loan_doc.name
+		loan_repayment_schedule.loan_product = frappe.db.get_value("Loan", loan_doc.name, "loan_type")
+		loan_repayment_schedule.loan_amount = loan_doc.loan_amount
+		loan_repayment_schedule.monthly_repayment_amount = loan_doc.monthly_repayment_amount
+		loan_repayment_schedule.posting_date = loan_doc.posting_date
+		loan_repayment_schedule.status = get_status(loan_doc.status)
 
 		repayment_schedules = frappe.db.get_all(
-			"Repayment Schedule", {"parent": loan.name}, "*", order_by="idx"
+			"Repayment Schedule", {"parent": loan_doc.name}, "*", order_by="idx"
 		)
 
 		for rs in repayment_schedules: