fix: add leaves to the correct allocation for compensatory leave request (backport #2615)

[mergify]

Problem

Leave Period: 1st Jan 2024 - 31st Dec 2024
Allocation 1: 1st Nov 2024 - 30 Nov 2024
Allocation 2: 1st Dec 2024 - 31st Dec 2024
Compensatory Leave Request: 1st Dec 2024

On submission of this compensatory leave request, 1 leave should be added applicable from 2nd Dec 2024 - 31st Dec 2024

We are greeted with this validation error from the leave ledger
To Date needs to be before From Date 🤡

This compensatory leave request is trying to update an existing allocation, but it fetches the first allocation from the entire period instead of the exact leave allocation date is falling into

So it's trying to create a ledger entry from 2nd Dec 2024 (comp leave applicable from) to 31st Mar 2024 (Allocation 1's from date)

Fix

Instead of finding first allocation in the leave period, find the exact allocation in which the compensatory leave falls

Also added more info to the validation and rectified the message

---

This is an automatic backport of pull request #2615 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of f20c15b has failed:

On branch mergify/bp/version-14-hotfix/pr-2615
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit f20c15bb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/compensatory_leave_request/test_compensatory_leave_request.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[frappe-pr-bot]

🎉 This PR is included in version 14.36.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀