Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch only HD Customer contacts #1624

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: fetch only HD Customer contacts #1624

merged 1 commit into from
Nov 27, 2023

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Nov 9, 2023 •
edited
Loading

Currently, system doesn't check if the fetched contact belongs to an HD Customer or not.
Added a where condition to fetch only HD Customer.

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Files Coverage Δ
helpdesk/utils.py 0.00% <0.00%> (ø)
...vice_level_agreement/hd_service_level_agreement.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

@rtdany10
Copy link
Contributor Author

@ssiyad

@cwerner1 cwerner1 mentioned this pull request Nov 13, 2023
Closed
@rtdany10
Copy link
Contributor Author

@ssiyad

@rtdany10
Copy link
Contributor Author

@ssiyad please check, it's a very simple fix and a required one

@rtdany10
Copy link
Contributor Author

@ssiyad @ankush

@ssiyad ssiyad merged commit 864d046 into frappe:main Nov 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtdany10 @ssiyad