fixed: Recursion when the tasks dependencies are wrong #114
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anurag810
suggested changes
Apr 29, 2019
| const deps = to_process.reduce((acc, curr) => { | ||
| // break if the loop is endless | ||
| counter++; | ||
| if(counter === 1000) { |
There was a problem hiding this comment.
1000 is an arbitrary number. It is not the best way for handling the recursion.
The recursion should be handled by the user it self while creating the task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem when I added on my bad wrong dependencies of the tasks. I started research in the library and I found that the dependencies are point themselves. For that reason, I put a counter to prevent the endless loop in the library.