fix: fix the formio-conten style #904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Robbert
requested changes
Sep 26, 2024
Robbert
reviewed
Sep 26, 2024
| } | ||
| &--warning { | ||
| --of-formio-content-warning-border-inline-start-style: none; | ||
| @include utrecht-alert; |
There was a problem hiding this comment.
Ik denk dat je de verkeerde component extend, de spotlight section is voor content.
There was a problem hiding this comment.
Ik wilde eerst de spotlight-component gebruiken, maar die heeft twee varianten, namelijk 'info' en 'warning', terwijl in OpenFormulier vier varianten staan ('success', 'info', 'error', 'warning').
There was a problem hiding this comment.
Net overlegd met @Ollie-nl: Je mag de error mappen naar de warning spotlight. Dus dan zijn er twee manieren om de warning spotlight te krijgen.
AliKdhim87
force-pushed
the
algin-formio-content-with-utrecht-alert-style
branch
from
ff95ded to
c16665b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo: