Lazy load description alterations

src/module/item/base/data/system.ts

@@ -110,6 +110,8 @@ interface ItemDescriptionData extends ItemDescriptionSource {
         contents: AlteredDescriptionContent[];
     }[];
     override: AlteredDescriptionContent[] | null;
+    /** True if lazy loaded description altering properties have been applied */
+    initialized?: boolean;
 }
 
 interface AlteredDescriptionContent {

src/module/item/helpers.ts

@@ -80,9 +80,17 @@ class ItemChatData {
 
     async #prepareDescription(): Promise<Pick<ItemDescriptionData, "value" | "gm">> {
         const { data, item } = this;
-        const rollOptions = new Set(
-            [item.actor?.getRollOptions(), item.getRollOptions("item")].flat().filter(R.isTruthy),
-        );
+        const actor = item.actor;
+
+        // Lazy load description alterations now that we need them
+        if (!data.description.initialized && actor) {
+            for (const alteration of actor.synthetics.itemAlterations.filter((i) => i.property === "description")) {
+                alteration.applyAlteration({ singleItem: item as ItemPF2e<ActorPF2e> });
+            }
+            data.description.initialized = true;
+        }
+
+        const rollOptions = new Set([actor?.getRollOptions(), item.getRollOptions("item")].flat().filter(R.isTruthy));
 
         const baseText = await (async (): Promise<string> => {
             const override = data.description?.override;

src/module/rules/rule-element/item-alteration/rule-element.ts

@@ -47,7 +47,10 @@ class ItemAlterationRuleElement extends RuleElementPF2e<ItemAlterationRuleSchema
     }
 
     /** Alteration properties that should be processed at the end of data preparation */
-    static #DELAYED_PROPERTIES = ["description", "pd-recovery-dc"];
+    static #DELAYED_PROPERTIES = ["pd-recovery-dc"];
+
+    /** Alteration properties that should only be processed when requested directly */
+    static #LAZY_PROPERTIES = ["description"];
 
     override async preCreate({ tempItems }: RuleElementPF2e.PreCreateParams): Promise<void> {
         if (this.ignored) return;
@@ -86,13 +89,17 @@ class ItemAlterationRuleElement extends RuleElementPF2e<ItemAlterationRuleSchema
 
     override onApplyActiveEffects(): void {
         this.actor.synthetics.itemAlterations.push(this);
-        if (!this.constructor.#DELAYED_PROPERTIES.includes(this.property)) {
+        const isLazy = this.constructor.#LAZY_PROPERTIES.includes(this.property);
+        const isDelayed = this.constructor.#DELAYED_PROPERTIES.includes(this.property);
+        if (!isLazy && !isDelayed) {
             this.applyAlteration();
         }
     }
 
     override afterPrepareData(): void {
-        if (this.constructor.#DELAYED_PROPERTIES.includes(this.property)) {
+        const isLazy = this.constructor.#LAZY_PROPERTIES.includes(this.property);
+        const isDelayed = this.constructor.#DELAYED_PROPERTIES.includes(this.property);
+        if (!isLazy && isDelayed) {
             this.applyAlteration();
         }
     }