[#3629, #4142] Add units to container capacity, add volume capacity #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks container capacity to allow for defining more than one capacity type (so a container can define a maximum number of items and a maximum weight). Weight capacity now accepts actual units so the weight can be measured in kilograms or tonnes if desired. Adds a volume capacity type to containers for measuring in cubic feet or liters. This includes the addition of `volumeUnits` to the configuration and a "Use Metric Volume Units" setting to match the other units settings. Closes #3629 Closes #4142
krbz999
reviewed
Dec 20, 2024
Fyorl
approved these changes
Jan 7, 2025
| @@ -275,14 +305,15 @@ export default class ContainerData extends ItemDataModel.mixin( | |||
| * @returns {Promise<Item5eCapacityDescriptor>} | |||
There was a problem hiding this comment.
This will need some future work I think. If we're changing container capacity from being exclusively items or weight, to inclusively items, weight, or volume, that implies to me that a container with item and weight capacities set would be considered exceeding its capacity when either of those two thresholds are met. So we no longer have a single capacity value, but instead multiple.
We could probably render multiple bars on the container sheet. That should look ok, I think, and this behaviour is something you opt-into by having both of these values filled-in. But either way, some of these internal capacity method signatures will need to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks container capacity to allow for defining more than one capacity type (so a container can define a maximum number of items and a maximum weight). Weight capacity now accepts actual units so the weight can be measured in kilograms or tonnes if desired.
Adds a volume capacity type to containers for measuring in cubic feet or liters. This includes the addition of
volumeUnitsto the configuration and a "Use Metric Volume Units" setting to match the other units settings.Closes #3629
Closes #4142