Multi-GPU switch from TorchRun to Accelerate #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianlim
requested review from
anhuong,
Ssukriti and
alex-jw-brooks
as code owners
fabianlim
force-pushed
the
flim/accelerate
branch
2 times, most recently
from
90968af to
7ce6a16
Compare
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
fabianlim
force-pushed
the
flim/accelerate
branch
from
7ce6a16 to
5056095
Compare
2 tasks
|
reviewed this and added any content from here that was missing in duplicate PR #92 . Have requested Mehant to co-commit so you both get credit. Thank you! |
|
merged as part of other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The current codebase recommends
torchrunfor multi-gpu training. Whiletorchrunis the de-facto way to launch distributed jobs, if used wrongly, it may be incompatible with huggingface trainers and models. The huggingface recommended approach is to useaccelerate(a layer built on top oftorchrun) to launch multi-gpu jpbs.Related issue number
Addresses #87 . Also in part addresses #80.
How to verify the PR
Test the run instructions given in the updated README.md
Was the PR tested
Had @VassilisVassiliadis and @fabianlim tested the scripts.