-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches dependencies from txt file to toml file #68
Switches dependencies from txt file to toml file #68
Conversation
Thank you for the help @lchu-ibm and @FilM for the help, I've switched back to the txt files and having the toml file pull up the dependencies from the txt files. |
Does someone have the ability to test the flash-attn |
I think @z103cb should review this. |
Thanks @tedhtchang, yes we need this so we can start with creating the wheel. @gkumbhat and @Ssukriti can you review too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the project.name
defined here is fms-hf-tuning
, but the package being installed is tuning
, probably because of the name of the main folder being tuning
. This makes the installation a bit confusing IMO.
Also I tried the pip install -e ".[flash-attn]
, but couldn't get flash-att
get installed as separate dependency
a3885e7
to
0cf764c
Compare
Oh my, well my rebase went crazy, was trying to fix the requirements file but now I'm getting all the last 3-4 weeks of changes, causing conflicts. Let me see if I can recover. Sorry |
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Bumps [aim](https://github.com/aimhubio/aim) from 3.17.5 to 3.18.1. - [Release notes](https://github.com/aimhubio/aim/releases) - [Changelog](https://github.com/aimhubio/aim/blob/main/CHANGELOG.md) - [Commits](aimhubio/aim@v3.17.5...v3.18.1) --- updated-dependencies: - dependency-name: aim dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sukriti Sharma <[email protected]>
* Add Contributing file Signed-off-by: James Busche <[email protected]> * add issue templates Signed-off-by: James Busche <[email protected]> * Adding Alex to CODEOWNERS Signed-off-by: James Busche <[email protected]> * Add ADR and squash info Signed-off-by: James Busche <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Sukriti Sharma <[email protected]> * NIT: Update CONTRIBUTING.md Signed-off-by: Sukriti Sharma <[email protected]> --------- Signed-off-by: James Busche <[email protected]> Signed-off-by: Sukriti Sharma <[email protected]> Co-authored-by: Sukriti Sharma <[email protected]>
* Add Contributing file Signed-off-by: James Busche <[email protected]> * add issue templates Signed-off-by: James Busche <[email protected]> * Adding Alex to CODEOWNERS Signed-off-by: James Busche <[email protected]> * Add ADR and squash info Signed-off-by: James Busche <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Sukriti Sharma <[email protected]> * NIT: Update CONTRIBUTING.md Signed-off-by: Sukriti Sharma <[email protected]> --------- Signed-off-by: James Busche <[email protected]> Signed-off-by: Sukriti Sharma <[email protected]> Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
0cf764c
to
0ded00c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me.
I'm still testing and making sure I understand/address the changes requested. |
Signed-off-by: James Busche <[email protected]>
I've made the name change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for contributing and making all the changes!
One suggestion for future iteration: We can look into getting rid of setup.py
by defining py-modules
or packages
in tool.setuptools
in pyproject.toml
Description of the change
This PR creates a pyproject.toml file and refers to the two requirements.txt and flashattn_requirements.txt files for dependencies.
Related issue number
Closes issue #56
How to verify the PR
I've been doing this:
On a Red Hat system (or a Mac system, skipping step 2 below)
Note: you'll need a twitter_complaints.json file that I can send you.
Was the PR tested