-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR/Issue templates #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssukriti
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, please see comments
Signed-off-by: ted chang <[email protected]>
Signed-off-by: ted chang <[email protected]>
Ssukriti
reviewed
Feb 29, 2024
Ssukriti
reviewed
Feb 29, 2024
Ssukriti
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes requested, then good to do
Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]>
Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]>
Ssukriti
approved these changes
Feb 29, 2024
jbusche
added a commit
to jbusche/fms-hf-tuning
that referenced
this pull request
Mar 1, 2024
* Add Contributing file Signed-off-by: James Busche <[email protected]> * Add PR/Issue templates (foundation-model-stack#65) * Add PR template Signed-off-by: ted chang <[email protected]> * Add Makefile Signed-off-by: ted chang <[email protected]> * Update .github/ISSUE_TEMPLATE/user_story.md Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]> * Update .github/pull_request_template.md Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]> --------- Signed-off-by: ted chang <[email protected]> Co-authored-by: Sukriti Sharma <[email protected]> * add issue templates Signed-off-by: James Busche <[email protected]> --------- Signed-off-by: James Busche <[email protected]> Signed-off-by: ted chang <[email protected]> Co-authored-by: ted chang <[email protected]> Co-authored-by: Sukriti Sharma <[email protected]>
anhuong
pushed a commit
to anhuong/fms-hf-tuning
that referenced
this pull request
Apr 3, 2024
* Add PR template Signed-off-by: ted chang <[email protected]> * Add Makefile Signed-off-by: ted chang <[email protected]> * Update .github/ISSUE_TEMPLATE/user_story.md Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]> * Update .github/pull_request_template.md Co-authored-by: Sukriti Sharma <[email protected]> Signed-off-by: ted chang <[email protected]> --------- Signed-off-by: ted chang <[email protected]> Co-authored-by: Sukriti Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this PR
Automatically create template to help the contributors with the PR descriptions
Description of the change
Added a PR/Issue templates and Makefile to run
make test
Related issue number
Also closes #66
How to verify the PR
The PR should automatically templated like this:
Was the PR tested
Yes. Manually tested in my own repo