Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR/Issue templates #65

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Add PR/Issue templates #65

merged 4 commits into from
Feb 29, 2024

Conversation

tedhtchang
Copy link
Collaborator

@tedhtchang tedhtchang commented Feb 27, 2024

Why do we need this PR

Automatically create template to help the contributors with the PR descriptions

Description of the change

Added a PR/Issue templates and Makefile to run make test

Related issue number

Also closes #66

How to verify the PR

The PR should automatically templated like this:
image
image

Was the PR tested

Yes. Manually tested in my own repo

Copy link
Collaborator

@Ssukriti Ssukriti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, please see comments

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Signed-off-by: ted chang <[email protected]>
@tedhtchang tedhtchang changed the title Add PR template Add PR/Issue templates Feb 29, 2024
Signed-off-by: ted chang <[email protected]>
Copy link
Collaborator

@Ssukriti Ssukriti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested, then good to do

tedhtchang and others added 2 commits February 29, 2024 10:06
Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>
Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>
@Ssukriti Ssukriti merged commit 5a0cf5c into foundation-model-stack:main Feb 29, 2024
2 checks passed
jbusche added a commit to jbusche/fms-hf-tuning that referenced this pull request Mar 1, 2024
* Add Contributing file

Signed-off-by: James Busche <[email protected]>

* Add PR/Issue templates (foundation-model-stack#65)

* Add PR template

Signed-off-by: ted chang <[email protected]>

* Add Makefile

Signed-off-by: ted chang <[email protected]>

* Update .github/ISSUE_TEMPLATE/user_story.md

Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>

* Update .github/pull_request_template.md

Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>

---------

Signed-off-by: ted chang <[email protected]>
Co-authored-by: Sukriti Sharma <[email protected]>

* add issue templates

Signed-off-by: James Busche <[email protected]>

---------

Signed-off-by: James Busche <[email protected]>
Signed-off-by: ted chang <[email protected]>
Co-authored-by: ted chang <[email protected]>
Co-authored-by: Sukriti Sharma <[email protected]>
anhuong pushed a commit to anhuong/fms-hf-tuning that referenced this pull request Apr 3, 2024
* Add PR template

Signed-off-by: ted chang <[email protected]>

* Add Makefile

Signed-off-by: ted chang <[email protected]>

* Update .github/ISSUE_TEMPLATE/user_story.md

Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>

* Update .github/pull_request_template.md

Co-authored-by: Sukriti Sharma <[email protected]>
Signed-off-by: ted chang <[email protected]>

---------

Signed-off-by: ted chang <[email protected]>
Co-authored-by: Sukriti Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fms-hf-tuning issue templates
2 participants