Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: function name from requires_agumentation to requires_augmentation #434

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

willmj
Copy link
Collaborator

@willmj willmj commented Jan 8, 2025

Nit fix for function in fms-acceleration which needs to be changed in fms-hf-tuning as well.
PR #118 in fms-acceleration should be merged at the same time.

Copy link

github-actions bot commented Jan 8, 2025

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

fabianlim
fabianlim previously approved these changes Jan 8, 2025
Copy link
Collaborator

@fabianlim fabianlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Will Johnson <[email protected]>
@fabianlim
Copy link
Collaborator

@willmj there is a problem with the image build action. The command docker rmi $(docker image ls -aq) fails because there are no existing images. So need to guard against that

@willmj willmj merged commit 6eb541d into foundation-model-stack:main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants