Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge set of changes for v2.1.0 #376

Merged
merged 9 commits into from
Oct 18, 2024
Merged

chore: merge set of changes for v2.1.0 #376

merged 9 commits into from
Oct 18, 2024

Conversation

aluu317
Copy link
Collaborator

@aluu317 aluu317 commented Oct 18, 2024

Description of the change

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

anhuong and others added 9 commits October 1, 2024 09:58
…er unit testing. (#348)

* cleanup: Move tokenizer_data_utils to /utils to /data, change imports

Signed-off-by: Will Johnson <[email protected]>

* tests: Add additional tests for test_embedding_resize to check resize with special tokens, resize multiple of. fmt

Signed-off-by: Will Johnson <[email protected]>

* lint

Signed-off-by: Will Johnson <[email protected]>

* fix: more thorough testing from output of function

Signed-off-by: Will Johnson <[email protected]>

* test: move assertion

Signed-off-by: Will Johnson <[email protected]>

---------

Signed-off-by: Will Johnson <[email protected]>
….14 (#354)

Updates the requirements on [peft](https://github.com/huggingface/peft) to permit the latest version.
- [Release notes](https://github.com/huggingface/peft/releases)
- [Commits](huggingface/peft@v0.8.0...v0.13.0)

---
updated-dependencies:
- dependency-name: peft
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anh Uong <[email protected]>
)

* deps: Upgrade accelerate to version 1.0.0

Signed-off-by: Will Johnson <[email protected]>

* tests: Replace out of date variable  with ,fixing unit tests

Signed-off-by: Will Johnson <[email protected]>

* fix: Add old parameter for backwards compatibility

Signed-off-by: Will Johnson <[email protected]>

---------

Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Co-authored-by: Anh Uong <[email protected]>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@aluu317 aluu317 changed the title release: merge set of changes for v2.1.0 chore: merge set of changes for v2.1.0 Oct 18, 2024
@github-actions github-actions bot added the chore label Oct 18, 2024
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing the most recent change from today to set upperbound of torch
deps: torch<2.5 due to FA2 error with new version

Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anhuong anhuong merged commit 8f16818 into release Oct 18, 2024
15 checks passed
@aluu317 aluu317 deleted the new_release_2.1.0 branch October 18, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants