Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enable_aim build args in all stages needed #337

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

anhuong
Copy link
Collaborator

@anhuong anhuong commented Sep 10, 2024

Description of the change

When I tried to build the image with AIM, it installed AIM correctly but didn't have the aim directory from the final stage since the build arg wasn't available in the final stage. This fixes the issue by defining enable_aim at the top and then enabling the flag in the stages where it is used.

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

@anhuong anhuong requested review from aluu317 and willmj September 12, 2024 16:34
Copy link
Collaborator

@willmj willmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willmj willmj merged commit 2ba7887 into foundation-model-stack:main Sep 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants