Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Add protobuf to support aLLaM models #336

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

willmj
Copy link
Collaborator

@willmj willmj commented Sep 10, 2024

Description of the change

Add protobuf to enable compatibility with certain models, as done in patch release v1.2.2

Related issue number

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

@anhuong
Copy link
Collaborator

anhuong commented Sep 10, 2024

Related PR into release branch - #328

@anhuong
Copy link
Collaborator

anhuong commented Sep 10, 2024

I initially was thinking we could pull in the same commit onto release branch to try to minimize the merge conflict at release time by doing something like git cherry-pick 1107e0042e7e4fdfa8e60f8fb33a03327b2278f6 but since this PR will squash merge into main branch, I don't think we can avoid having the same change but different commits on main and release branch. I don't think it should be too much of an issue at release time since they are the same change, but we shall see.

@anhuong anhuong changed the title deps: Add protobuf to enable compatibility with certain models deps: Add protobuf to support aLLaM models Sep 10, 2024
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in and not forgetting Will!

@anhuong anhuong merged commit 2144f1a into foundation-model-stack:main Sep 10, 2024
7 checks passed
aluu317 pushed a commit to aluu317/fms-hf-tuning that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants