Add formatting function alpaca #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti Sharma <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
|
@alex-jw-brooks the PR is ready for review now. I will address your existing comments soon. Thank you |
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
|
I have manually verified that formatted data matches our pre-processing step and no warnings occur while training . We will do another quality test to be safe before 0.2.0 release. Safe to merge PR though |
alex-jw-brooks
requested changes
May 28, 2024
Signed-off-by: Sukriti-Sharma4 <[email protected]>
Signed-off-by: Sukriti-Sharma4 <[email protected]>
|
@alex-jw-brooks the PR is ready for review |
alex-jw-brooks
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allows passing a data formatter template to create single sequence of dataset_text_field internally with JSONL supplied . Eliminates need to do preprocessing and format data to alpaca style https://github.com/foundation-model-stack/fms-hf-tuning?tab=readme-ov-file#data-format
Adds a new data_formatter field to args similar to SFT Trainer formatting function https://huggingface.co/docs/trl/en/sft_trainer#trl.SFTTrainer
Similarly, users either need to pass a dataset_text_field in JSON with preformatted template or can pass a formatter to do formatting on the fly
Related issue number
https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/863
How to verify the PR
Was the PR tested