Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copying over logs #114

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix copying over logs #114

merged 1 commit into from
Apr 10, 2024

Conversation

tharapalanivel
Copy link
Collaborator

@tharapalanivel tharapalanivel commented Apr 10, 2024 •
edited
Loading

Description of the change

Fix copying over logs when num_processes>1

Related issue number

How to verify the PR

Built new image, ran a sample job on test cluster and checked training_logs.jsonl was copied over

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

@tharapalanivel
Fix copying over logs
577d77f 
Signed-off-by: Thara Palanivel <[email protected]>
@Ssukriti Ssukriti merged commit cdcddce into foundation-model-stack:main Apr 10, 2024
3 checks passed
@anhuong anhuong mentioned this pull request May 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ssukriti Ssukriti Ssukriti approved these changes

@anhuong anhuong Awaiting requested review from anhuong anhuong is a code owner

@alex-jw-brooks alex-jw-brooks Awaiting requested review from alex-jw-brooks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tharapalanivel @Ssukriti