feat: Migrating the trainer controller to python logger (#309)

* fix: Migrate tranformer logging to python logging Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Migrate tranformer logging to python logging Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed unwanted file Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Log levels obtained from reversing the dictionary Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Format issues Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Variable names made meaningful Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed unwanted log line Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Added name to getLogger Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Added default logging level to DEBUG Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Added default logging level to DEBUG Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Added default logging level to DEBUG Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed setLevel() calls from the packages Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Format issues resolved Signed-off-by: Padmanabha V Seshadri <[email protected]> --------- Signed-off-by: Padmanabha V Seshadri <[email protected]>
foundation-model-stack · Sep 5, 2024 · 5946949 · 5946949
1 parent 5c09dbc
commit 5946949
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 21 deletions.
diff --git a/tuning/trainercontroller/callback.py b/tuning/trainercontroller/callback.py
@@ -18,6 +18,7 @@
 # Standard
 from typing import Dict, List, Union
 import inspect
+import logging
 import os
 import re
 
@@ -29,7 +30,6 @@
     TrainerState,
     TrainingArguments,
 )
-from transformers.utils import logging
 import yaml
 
 # Local
@@ -45,7 +45,7 @@
 from tuning.trainercontroller.patience import PatienceControl
 from tuning.utils.evaluator import MetricUnavailableError, RuleEvaluator
 
-logger = logging.get_logger(__name__)
+logger = logging.getLogger(__name__)
 
 # Configuration keys
 CONTROLLER_METRICS_KEY = "controller_metrics"
@@ -66,7 +66,7 @@
 DEFAULT_OPERATIONS = {"operations": [{"name": "hfcontrols", "class": "HFControls"}]}
 DEFAULT_METRICS = {}
 DEFAULT_CONFIG = {}
-DEFAULT_TRIGGER_LOG_LEVEL = "debug"
+DEFAULT_TRIGGER_LOG_LEVEL = "DEBUG"
 
 # pylint: disable=too-many-instance-attributes
 class TrainerControllerCallback(TrainerCallback):
@@ -305,7 +305,7 @@ def on_init_end(
         kwargs["state"] = state
         kwargs["control"] = control
 
-        log_levels = logging.get_log_levels_dict()
+        log_levels = dict((value, key) for key, value in logging._levelToName.items())
         # Check if there any metrics listed in the configuration
         if (
             CONTROLLER_METRICS_KEY not in self.trainer_controller_config
@@ -407,7 +407,7 @@ def on_init_end(
                         control.config = controller[CONTROLLER_CONFIG_KEY]
                         config_log_level_str = control.config.get(
                             CONTROLLER_CONFIG_TRIGGER_LOG_LEVEL, config_log_level_str
-                        )
+                        ).upper()
                         if config_log_level_str not in log_levels:
                             logger.warning(
                                 "Incorrect trigger log-level [%s] specified in the config."

diff --git a/tuning/trainercontroller/controllermetrics/trainingstate.py b/tuning/trainercontroller/controllermetrics/trainingstate.py
@@ -21,13 +21,10 @@
 
 # Third Party
 from transformers import TrainerState
-from transformers.utils import logging
 
 # Local
 from tuning.trainercontroller.controllermetrics.metricshandler import MetricHandler
 
-logger = logging.get_logger(__name__)
-
 
 class TrainingState(MetricHandler):
     """Implements the controller metric which exposes the trainer state"""

diff --git a/tuning/trainercontroller/operations/hfcontrols.py b/tuning/trainercontroller/operations/hfcontrols.py
@@ -10,6 +10,8 @@
 # Local
 from .operation import Operation
 
+logger = logging.getLogger(__name__)
+
 
 class HFControls(Operation):
     """Implements the control actions for the HuggingFace controls in
@@ -37,7 +39,7 @@ def control_action(self, control: TrainerControl, **kwargs):
             control: TrainerControl. Data class for controls.
             kwargs: List of arguments (key, value)-pairs
         """
-        logging.debug("Arguments passed to control_action: %s", repr(kwargs))
+        logger.debug("Arguments passed to control_action: %s", repr(kwargs))
         frame_info = inspect.currentframe().f_back
         arg_values = inspect.getargvalues(frame_info)
         setattr(control, arg_values.locals["action"], True)
diff --git a/tuning/trainercontroller/operations/logcontrol.py b/tuning/trainercontroller/operations/logcontrol.py
@@ -1,12 +1,13 @@
+# Standard
+import logging
+
 # Third Party
 from transformers import TrainingArguments
-from transformers.utils import logging
 
 # Local
 from .operation import Operation
 
-logger = logging.get_logger(__name__)
-logger.setLevel(level=logging.DEBUG)
+logger = logging.getLogger(__name__)
 
 
 class LogControl(Operation):
@@ -20,12 +21,11 @@ def __init__(self, log_format: str, log_level: str, **kwargs):
         Args:
             kwargs: List of arguments (key, value)-pairs
         """
-        log_levels = logging.get_log_levels_dict()
-        if log_level not in log_levels:
+        self.log_level = getattr(logging, log_level.upper(), None)
+        if not isinstance(self.log_level, int):
             raise ValueError(
                 "Specified log_level [%s] is invalid for LogControl" % (log_level)
             )
-        self.log_level = log_levels[log_level]
         self.log_format = log_format
         super().__init__(**kwargs)
 

diff --git a/tuning/trainercontroller/operations/operation.py b/tuning/trainercontroller/operations/operation.py
@@ -1,12 +1,10 @@
 # Standard
 import abc
 import inspect
+import logging
 import re
 
-# Third Party
-from transformers.utils import logging
-
-logger = logging.get_logger(__name__)
+logger = logging.getLogger(__name__)
 
 
 class Operation(metaclass=abc.ABCMeta):

diff --git a/tuning/trainercontroller/patience.py b/tuning/trainercontroller/patience.py
@@ -31,6 +31,8 @@
 # will be exceeded afer the fifth event.
 MODE_NO_RESET_ON_FAILURE = "no_reset_on_failure"
 
+logger = logging.getLogger(__name__)
+
 
 class PatienceControl:
     """Implements the patience control for every rule"""
@@ -49,7 +51,7 @@ def should_tolerate(
         elif self._mode == MODE_RESET_ON_FAILURE:
             self._patience_counter = 0
         if self._patience_counter <= self._patience_threshold:
-            logging.debug(
+            logger.debug(
                 "Control {} triggered on event {}: "
                 "Enforcing patience [patience_counter = {:.2f}, "
                 "patience_threshold = {:.2f}]".format(
@@ -60,7 +62,7 @@ def should_tolerate(
                 )
             )
             return True
-        logging.debug(
+        logger.debug(
             "Control {} triggered on event {}: "
             "Exceeded patience [patience_counter = {:.2f}, "
             "patience_threshold = {:.2f}]".format(