Move sklearn to optional, install optionals for linting (#117)

Signed-off-by: Alex-Brooks <[email protected]>
foundation-model-stack · Apr 11, 2024 · 37919ab · 37919ab
1 parent 56a6a8d
commit 37919ab
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -22,7 +22,7 @@ classifiers=[
 dynamic = ["dependencies"]
 
 [project.optional-dependencies]
-dev = ["wheel", "packaging", "ninja"]
+dev = ["wheel", "packaging", "ninja", "scikit-learn>=1.0, <2.0"]
 flash-attn = ["flash-attn"]
 aim = ["aim==3.18.1"]
 

diff --git a/requirements.txt b/requirements.txt
@@ -9,7 +9,3 @@ trl
 peft>=0.8.0
 datasets>=2.15.0
 fire
-
-# Dependencies needed only to run scripts.
-# TODO: Figure out a better place to put these.
-scikit-learn>=1.0, <2.0
diff --git a/tox.ini b/tox.ini
@@ -18,6 +18,7 @@ allowlist_externals = ./scripts/fmt.sh
 description = lint with pylint
 deps = pylint>=2.16.2,<=3.1.0
         pytest
+        .[dev]
         -r requirements.txt
 commands = pylint tuning scripts/*.py build/*.py tests
 allowlist_externals = pylint