-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add thresholding for detector results #52
Merged
evaline-ju
merged 14 commits into
foundation-model-stack:main
from
evaline-ju:detector-threshold
May 30, 2024
Merged
✨ Add thresholding for detector results #52
evaline-ju
merged 14 commits into
foundation-model-stack:main
from
evaline-ju:detector-threshold
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]> Co-authored-by: declark1 <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]> Co-authored-by: declark1 <[email protected]>
declark1
reviewed
May 29, 2024
Signed-off-by: Evaline Ju <[email protected]>
evaline-ju
force-pushed
the
detector-threshold
branch
from
May 30, 2024 18:34
1d5b38b
to
d425520
Compare
Signed-off-by: Evaline Ju <[email protected]>
evaline-ju
force-pushed
the
detector-threshold
branch
from
May 30, 2024 18:36
d425520
to
9cce8b0
Compare
declark1
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just once last suggested change inline.
Signed-off-by: Evaline Ju <[email protected]> Co-authored-by: declark1 <[email protected]>
declark1
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #51 , score thresholding for detector results will be done by the orchestrator. Each detector will need a configured
default_threshold
, expected to be added when the detector is added to the orchestrator config.If a user provides a threshold through the API, this will be used. Otherwise the default threshold will be used.
Example config parts API that should give the same output if
default_threshold
: 0.5 were configured for detectormodel_name
This PR also adds documentation/comments for the config structs and updates the validation error for request validation from #42.
For: #24