Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Empty masks same as no masks #43

Merged
merged 2 commits into from
May 22, 2024

Conversation

evaline-ju
Copy link
Collaborator

@evaline-ju evaline-ju commented May 22, 2024

Tested with calls in #41 - now return the same response

Closes: #41

evaline-ju and others added 2 commits May 22, 2024 16:37
Signed-off-by: Evaline Ju <[email protected]>

Co-authored-by: declark1 <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
@evaline-ju evaline-ju marked this pull request as ready for review May 22, 2024 23:15
Copy link
Collaborator

@declark1 declark1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evaline-ju evaline-ju merged commit 3e38689 into foundation-model-stack:main May 22, 2024
1 check passed
@evaline-ju evaline-ju deleted the empty-masks branch May 22, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty masks array leads to different behavior/results on unary endpoint
2 participants