-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable unit testing #234
Disable unit testing #234
Conversation
Reviewer's Guide by SourceryThis pull request removes the ability to run tests as unit tests by eliminating the code for recording and replaying serial traffic. The tests will now only function as integration tests, requiring a real PSLab device to be connected. The changes primarily affect the test infrastructure and how tests are executed, without modifying the core functionality of the PSLab library itself. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bessman - I've reviewed your changes - here's some feedback:
Overall Comments:
- While simplifying the testing approach is understandable, completely removing unit tests in favor of integration tests only could make development and CI more challenging. Consider keeping a small set of critical unit tests with recorded data to maintain some level of quick, hardware-independent testing.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 7 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
This is a good idea but will be done in a separate pull request. The old method of recording and replaying serial traffic is obsolete, and should be removed in favor of pytest-reserial anyway. |
0d06012
to
7cc9691
Compare
This pull request removes the ability to run the tests as unit tests, by removing the code for recording and replaying serial traffic.
The tests remain useful as integration tests, but the maintenance overhead of re-recording serial traffic for every little change in order for the unit tests to pass has proven prohibitive.
Summary by Sourcery
Disable unit testing by removing the code for recording and replaying serial traffic, transitioning tests to function as integration tests. Update test fixtures accordingly and remove the test job from the CI workflow.
Enhancements:
CI:
Tests:
Chores: