Add ky to fetch data from server #350

progmatic-99 · 2022-03-04T11:16:39Z

Fixes #300

vercel · 2022-03-04T11:16:44Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-next/JBbK68o7ViLPkAaRfbFxwZizbkbG
✅ Preview: https://open-event-next-git-fork-progmatic-99-ky-eventyay.vercel.app

pc-beast · 2022-03-04T17:27:39Z

Please see....build is failing

pc-beast · 2022-03-09T12:57:44Z

pages/index.tsx

+    {
+      name: 'is-promoted',
+      op: 'eq',
+      val: true,
+    },
+  ])
+  const [group, groupErr] = await fetcher(
+    'groups',
+    `filter=${promotedGroupFilter}&include=user,follower&page[size]=3&public=true`
+  )


Can we refactor the other api calls in some similar way. It will make easier to debug the system.

pc-beast · 2022-03-09T13:01:31Z

utils/fetcher.ts

+  searchParams: string
+): Promise<[data: ServerProp | null, err: any]> {


pass a parameter for API call method too. Right now we can only make get requests.

pc-beast · 2022-03-09T13:01:32Z

utils/fetcher.ts

+  searchParams: string
+): Promise<[data: ServerProp | null, err: any]> {


pass a parameter for API call method too. Right now we can only make get requests.

progmatic-99 · 2022-03-11T13:06:36Z

pages/index.tsx

-  const [event, eventErr] = await fetcher(eventUrl)
+  const [event, eventErr] = await fetcher(
+    'events',
+    'filter=%5B%7B%22and%22%3A%5B%7B%22name%22%3A%22state%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22published%22%7D%2C%7B%22name%22%3A%22privacy%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22public%22%7D%2C%7B%22or%22%3A%5B%7B%22name%22%3A%22is-featured%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22name%22%3A%22is-promoted%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22and%22%3A%5B%7B%22name%22%3A%22logo-url%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22original-image-url%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-topic%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-sub-topic%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-type%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%5D%7D%5D%7D%2C%7B%22name%22%3A%22is-sessions-speakers-enabled%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22name%22%3A%22is-demoted%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Afalse%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22privacy%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22public%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22starts-at%22%2C%22op%22%3A%22le%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.823Z%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22ends-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.823Z%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22announcement%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%7D%5D%7D%2C%7B%22or%22%3A%5B%7B%22name%22%3A%22ends-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.822Z%22%7D%2C%7B%22name%22%3A%22starts-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.822Z%22%7D%5D%7D%5D&include=event-topic%2Cevent-sub-topic%2Cevent-type%2Cspeakers-call&page%5Bsize%5D=6&public=true&sort=starts-at'


I just added it for testing. We should refactor it in the way I did below for groups with correct parameters.

pc-beast · 2022-03-09T12:57:44Z

pages/index.tsx

+    {
+      name: 'is-promoted',
+      op: 'eq',
+      val: true,
+    },
+  ])
+  const [group, groupErr] = await fetcher(
+    'groups',
+    `filter=${promotedGroupFilter}&include=user,follower&page[size]=3&public=true`
+  )


Can we refactor the other api calls in some similar way. It will make easier to debug the system.

pc-beast · 2022-03-11T16:19:06Z

pages/index.tsx

-  const [event, eventErr] = await fetcher(eventUrl)
+  const [event, eventErr] = await fetcher(
+    'events',
+    'filter=%5B%7B%22and%22%3A%5B%7B%22name%22%3A%22state%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22published%22%7D%2C%7B%22name%22%3A%22privacy%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22public%22%7D%2C%7B%22or%22%3A%5B%7B%22name%22%3A%22is-featured%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22name%22%3A%22is-promoted%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22and%22%3A%5B%7B%22name%22%3A%22logo-url%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22original-image-url%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-topic%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-sub-topic%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%2C%7B%22name%22%3A%22event-type%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%5D%7D%5D%7D%2C%7B%22name%22%3A%22is-sessions-speakers-enabled%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Atrue%7D%2C%7B%22name%22%3A%22is-demoted%22%2C%22op%22%3A%22eq%22%2C%22val%22%3Afalse%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22privacy%22%2C%22op%22%3A%22eq%22%2C%22val%22%3A%22public%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22starts-at%22%2C%22op%22%3A%22le%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.823Z%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22ends-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.823Z%22%7D%7D%2C%7B%22name%22%3A%22speakers-call%22%2C%22op%22%3A%22has%22%2C%22val%22%3A%7B%22name%22%3A%22announcement%22%2C%22op%22%3A%22ne%22%2C%22val%22%3Anull%7D%7D%5D%7D%2C%7B%22or%22%3A%5B%7B%22name%22%3A%22ends-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.822Z%22%7D%2C%7B%22name%22%3A%22starts-at%22%2C%22op%22%3A%22ge%22%2C%22val%22%3A%222022-03-09T11%3A52%3A46.822Z%22%7D%5D%7D%5D&include=event-topic%2Cevent-sub-topic%2Cevent-type%2Cspeakers-call&page%5Bsize%5D=6&public=true&sort=starts-at'


I just added it for testing. We should refactor it in the way I did below for groups with correct parameters.

progmatic-99 · 2022-03-30T17:47:54Z

Build working on my local, not here

progmatic-99 added 2 commits March 4, 2022 16:42

feat: add ky to fetch data

cfb442f

f

633f88f

vercel bot had a problem deploying to Preview March 4, 2022 11:16 Failure

progmatic-99 requested review from mariobehling and pc-beast March 4, 2022 11:18

hongquan previously approved these changes Mar 4, 2022

View reviewed changes

Merge branch 'master' of github.com:fossasia/open-event-next into ky

5ce887b

pc-beast dismissed hongquan’s stale review via 54b8c90 March 9, 2022 12:56

vercel bot deployed to Preview March 9, 2022 12:56 View deployment

pc-beast reviewed Mar 9, 2022

View reviewed changes

vercel bot deployed to Preview March 9, 2022 13:01 View deployment

progmatic-99 commented Mar 11, 2022

View reviewed changes

vercel bot deployed to Preview March 11, 2022 16:17 View deployment

pc-beast reviewed Mar 11, 2022

View reviewed changes

progmatic-99 added 2 commits March 29, 2022 12:56

Merge branch 'master' of github.com:fossasia/open-event-next into ky

2c9eca3

complete pr

c2cf0f3

progmatic-99 force-pushed the ky branch from 8363def to c2cf0f3 Compare March 29, 2022 07:28

vercel bot had a problem deploying to Preview March 29, 2022 07:29 Failure

fix

08c585f

vercel bot had a problem deploying to Preview March 29, 2022 07:47 Failure

progmatic-99 added 2 commits March 29, 2022 15:11

fix build

5929e32

Merge branch 'master' of github.com:fossasia/open-event-next into ky

85161d6

vercel bot had a problem deploying to Preview March 29, 2022 09:44 Failure

change date to ISO string

2151579

vercel bot had a problem deploying to Preview March 29, 2022 09:49 Failure

progmatic-99 added 2 commits March 30, 2022 10:44

Merge branch 'master' of github.com:fossasia/open-event-next into ky

bdd4dd4

fix again

5501f7d

vercel bot had a problem deploying to Preview March 30, 2022 06:58 Failure

fixed build

4e16cc3

vercel bot deployed to Preview March 30, 2022 17:16 View deployment

f

6b01f40

vercel bot deployed to Preview March 30, 2022 17:36 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ky to fetch data from server #350

Add ky to fetch data from server #350

progmatic-99 commented Mar 4, 2022

vercel bot commented Mar 4, 2022 •

edited

Loading

pc-beast commented Mar 4, 2022

pc-beast Mar 9, 2022

pc-beast Mar 9, 2022

pc-beast Mar 9, 2022

progmatic-99 Mar 11, 2022

pc-beast Mar 11, 2022

pc-beast Mar 9, 2022

pc-beast Mar 11, 2022

progmatic-99 commented Mar 30, 2022

		searchParams: string
		): Promise<[data: ServerProp \| null, err: any]> {

Add ky to fetch data from server #350

Are you sure you want to change the base?

Add ky to fetch data from server #350

Conversation

progmatic-99 commented Mar 4, 2022

vercel bot commented Mar 4, 2022 • edited Loading

pc-beast commented Mar 4, 2022

pc-beast Mar 9, 2022

Choose a reason for hiding this comment

pc-beast Mar 9, 2022

Choose a reason for hiding this comment

pc-beast Mar 9, 2022

Choose a reason for hiding this comment

progmatic-99 Mar 11, 2022

Choose a reason for hiding this comment

pc-beast Mar 11, 2022

Choose a reason for hiding this comment

pc-beast Mar 9, 2022

Choose a reason for hiding this comment

pc-beast Mar 11, 2022

Choose a reason for hiding this comment

progmatic-99 commented Mar 30, 2022

vercel bot commented Mar 4, 2022 •

edited

Loading