Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adresses #810, #433: Keep space between heading and text in user-info-box #825

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

simsausaurabh
Copy link
Member

Changes proposed in this pull request

  • Keep proper spacing between heading and text in user-info-box.

Screenshots (if appropriate)

Link to live demo: http://pr-825-fossasia-loklaksearch.surge.sh

Closes #
Addresses: #433, #810.

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #825 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #825      +/-   ##
===============================================
- Coverage        50.51%   50.47%   -0.04%     
===============================================
  Files              107      107              
  Lines             2643     2643              
  Branches           292      292              
===============================================
- Hits              1335     1334       -1     
- Misses            1279     1281       +2     
+ Partials            29       28       -1
Impacted Files Coverage Δ
src/app/lazy-img/lazy-img.service.ts 51.11% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2227833...351f623. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results has stopped coming now. Unable to review 😟
image

@simsausaurabh
Copy link
Member Author

@praveenojha33 Results are coming now, please review again! Thanks.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit 8506e7e into fossasia:development Jul 5, 2018
@simsausaurabh simsausaurabh deleted the overflowtext branch July 5, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants