-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch from numtide/flake-utils
to flake-parts
#206
base: master
Are you sure you want to change the base?
Conversation
9e16be6
to
21a0f3a
Compare
Do you have a reference for the controversy? To be honest, I am not really fond of switching to these opinionated flake helpers since they veer too far from how flakes work, making them harder to understand without looking at the implementation. Especially when there is so many of them, each slightly different. |
21a0f3a
to
c4f3d94
Compare
I understand and I overall share the same feeling. That said, from my thin experience with Nix flakes and Nix in general, I always found this a bit odd to require an external contrib package( As seen on Reddit,
Also, on Matrix, I often see people confirming those sayings. I'm just proposing here, feel free to close if you don't like it. |
c4f3d94
to
245af66
Compare
Yeah, I am still not convinced. It would just be trading one flake input for another, still just to get a single mostly trivial function. (I did not even bother switching to flake-utils in my personal config when flake-utils became popular.) And while I like the API, it is still new and deviates from Flakes too much. Maybe we can re-evaluate later, perhaps when NixOS/nix#3843 moves along. |
Ok, let's see how it goes! |
Closing the PR in the meantime. |
245af66
to
c57bd75
Compare
Since using
numtide/flake-utils
is getting controversial for many reasons, this PR usesflake-parts
(https://github.com/hercules-ci/flake-parts).