Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from numtide/flake-utils to flake-parts #206

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jan 29, 2023

Since using numtide/flake-utils is getting controversial for many reasons, this PR uses flake-parts (https://github.com/hercules-ci/flake-parts).

@drupol drupol force-pushed the switch-to-flake-parts branch 2 times, most recently from 9e16be6 to 21a0f3a Compare January 29, 2023 18:12
@jtojnar
Copy link
Member

jtojnar commented Jan 29, 2023

Do you have a reference for the controversy?

To be honest, I am not really fond of switching to these opinionated flake helpers since they veer too far from how flakes work, making them harder to understand without looking at the implementation. Especially when there is so many of them, each slightly different.

@drupol
Copy link
Collaborator Author

drupol commented Jan 29, 2023

I understand and I overall share the same feeling.

That said, from my thin experience with Nix flakes and Nix in general, I always found this a bit odd to require an external contrib package(numtide/flake-utils) to build a flake for different architectures.

As seen on Reddit, flake-parts is by default in Nix package and:

IMO, flake-parts has quite a bit better potential as well as being more useful today. NixOS-modules style option declaration and typing has much more opportunity for ergonomic and modular flake consumption.

Also, on Matrix, I often see people confirming those sayings.

I'm just proposing here, feel free to close if you don't like it.

@jtojnar
Copy link
Member

jtojnar commented Feb 17, 2023

Yeah, I am still not convinced. It would just be trading one flake input for another, still just to get a single mostly trivial function. (I did not even bother switching to flake-utils in my personal config when flake-utils became popular.) And while I like the API, it is still new and deviates from Flakes too much. Maybe we can re-evaluate later, perhaps when NixOS/nix#3843 moves along.

@drupol
Copy link
Collaborator Author

drupol commented Feb 17, 2023

Ok, let's see how it goes!

@drupol
Copy link
Collaborator Author

drupol commented Feb 17, 2023

Closing the PR in the meantime.

@drupol drupol closed this Feb 17, 2023
@drupol drupol reopened this Feb 1, 2024
@drupol drupol marked this pull request as draft February 1, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants