Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace outdated Github action with Nix and Prettify #198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jan 14, 2023

This PR:

  • Replace the Github action with Nix Prettify command

@drupol
Copy link
Collaborator Author

drupol commented Jan 14, 2023

@jtojnar WDYT about this?

@drupol drupol marked this pull request as ready for review January 14, 2023 12:12
@jtojnar
Copy link
Member

jtojnar commented Jan 14, 2023

I do not think prettier will check Nix files? Also the workflow should probably be renamed. And the formatting should be performed before checks so that there are no red commits.

@drupol
Copy link
Collaborator Author

drupol commented Jan 14, 2023

I do not think prettier will check Nix files? Also the workflow should probably be renamed. And the formatting should be performed before checks so that there are no red commits.

Indeed, prettier does not check .nix files, this is why I'm introducing #190 as well.

I will rebase the commits to fit your request right now.

@drupol drupol force-pushed the ci/update-editorconfig-checks-workflow branch from 814fe03 to e93204d Compare January 14, 2023 22:25
@shyim
Copy link
Contributor

shyim commented Jan 16, 2023

Can you not run configure nix fmt and then use that tool here and check that the git diff is empty?

@drupol
Copy link
Collaborator Author

drupol commented Jan 16, 2023

prettier does not format .nix files, so, it would be useless to do that.

For nix files, I created this PR: #190

@drupol drupol mentioned this pull request Feb 12, 2023
1 task
@drupol drupol force-pushed the ci/update-editorconfig-checks-workflow branch from e93204d to 2925047 Compare February 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants