Don't free-up file-descriptor of stdin/stdout/stderr #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout, stdin and stderr are statically allocated at tinystdio/posixiob_stdout.c, tinystdio/posixiob_stdin.c and tinystdio/posixiob_stderr.c respectively. and the issue here is that the current implementation of `fclose()` frees the allocated memory for the stream file. When we call `fclose(stdout)` it tries to free an unallocated memory for _stdout_, so it frees a wrong pointer and saves it as a free heap space, then when trying to use this memory it causes memory corruption. So, we shouldn't free the memory if the stream is stdin, stdout or stderr.
mostafa-salmaan
pushed a commit
that referenced
this pull request
Aug 28, 2024
- The PRU newlib port is supposed to implement case #2 as described in newlib/libc/include/reent.h . Thus drop the defining of MISSING_SYSCALL_NAMES. - libgloss/configure: Regenerate. - libgloss/libnosys/acinclude.m4: Do not define MISSING_SYSCALL_NAMES for pru. Signed-off-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdout, stdin and stderr are statically allocated at tinystdio/posixiob_stdout.c, tinystdio/posixiob_stdin.c and tinystdio/posixiob_stderr.c respectively.
and the issue here is that the current implementation of
fclose()frees the allocated memory for the stream file. When we callfclose(stdout)it tries to free an unallocated memory forstdout, so it frees a wrong pointer and saves it as a free heap space, then when trying to use this memory it causes memory corruption.So, we shouldn't free the memory if the stream is stdin, stdout or stderr.