Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9607 GoogleAddressProvider: Check for browser API in tryRemoveLibrary #5979

Closed
wants to merge 1 commit into from

Conversation

blakekrammes
Copy link
Contributor

@blakekrammes blakekrammes commented Jan 14, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9607

Description

What changed?

Add check for document.querySelector in GoogleAdressProvider's tryRemoveLibrary fn .

Why have you chosen this solution?

  • To my best understanding, we had a failing test in the OS formio API because:
    if an address component with a Google provider was rendered via the API, it resulted in an error since
    document.querySelector was undefined

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Existing automated tests pass in this repo.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

blakekrammes added a commit to formio/formio that referenced this pull request Jan 14, 2025
blakekrammes added a commit to formio/formio that referenced this pull request Jan 14, 2025
@blakekrammes blakekrammes force-pushed the fio-9607 branch 2 times, most recently from 3f881d8 to 2bccb41 Compare January 14, 2025 19:34
blakekrammes added a commit to formio/formio that referenced this pull request Jan 14, 2025
…rary

  - To my best understanding,  we had a failing test in the OS formio API because:
  - If an address component with a Google provider was rendered via the API, it resulted in an error
blakekrammes added a commit to formio/formio that referenced this pull request Jan 14, 2025
@blakekrammes blakekrammes marked this pull request as ready for review January 14, 2025 21:57
@blakekrammes
Copy link
Contributor Author

Closing in favor of the better solution: https://github.com/formio/vm/pull/44

Props to Brendan

@blakekrammes blakekrammes deleted the fio-9607 branch January 15, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant