Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 8151: allow for reference attr name #5567

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8151

Description

Form.io renders forms by attaching to component's internal "ref" attributes. However, in React e.g., the "ref" attribute is a reserved keyword for a similar functionality that allows React access to DOM elements. In order to use override component templates using JSX (and potentially other paradims such as Web Components), we'll need the reference attribute name to be configurable.

Dependencies

n/a

How has this PR been tested?

All existing automated tests pass. I'm looking into testing the renders

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 12bcdc9 into master Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants