Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7733: export eventemitter #5507

Merged
merged 2 commits into from
Apr 23, 2024
Merged

FIO-7733: export eventemitter #5507

merged 2 commits into from
Apr 23, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7733

Description

Our @formio/react library makes use of an EventEmitter class from eventemitter2 that exposes an onAny method. Newer versions of the @formio/js renderer extend a similar class from eventemitter3, so this PR just consolidates our usage of the EventEmitter to the one extended in @formio/js (in effect making it the "source of truth" EventEmitter), which should serve to make the overall interface a little bit cleaner and reduce the dependency load in @formio/react.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 91170ef into master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants